Backend/src/services/soroban service.ts#970
Open
extolkom wants to merge 2 commits into
Open
Conversation
…ub.com/extolkom/flowfi into backend/src/services/sorobanService.ts
Contributor
|
heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #807
Summary
tests/soroban.service.test.ts previously only covered isStale, leaving the fund-handling and chain-decoding logic in sorobanService.ts untested. This PR adds unit tests for the remaining critical paths.
Changes
submitContractCall: added tests for the simulation-error branch and the sendTransaction ERROR status branch, using a mocked rpc.Server so no live network calls are made.
getStreamFromChain / getClaimableFromChain: added happy-path tests asserting correct decoding of chain data, plus tests confirming both functions return null (rather than throwing) when XDR decoding fails.
decodeI128 / decodeAddress: added tests covering positive and negative i128 values (including boundary/sign-bit cases) and both account (G...) and contract (C...) address decoding.
topUpStream: added a test asserting it throws when KEEPER_SECRET_KEY is unset in the environment, guarding against accidental deploys without the keeper key configured.
Testing
All new tests run against mocked rpc.Server responses, no testnet/mainnet calls are made, and the existing isStale test suite is unaffected. Ran the full suite locally — all green.
Files touched
backend/tests/soroban.service.test.ts
backend/src/services/sorobanService.ts